Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update locale examples #80

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Update locale examples #80

merged 2 commits into from
Feb 6, 2022

Conversation

Andre601
Copy link
Contributor

@Andre601 Andre601 commented Feb 6, 2022

The examples under the locales section seem to be slightly incorrect.

I noticed this, because by default was the format <month> <day>, <year> or <month> <day>, <year> <hours>:<minutes>:<seconds> for me and when I set locale to en did nothing change.

Personally speaking is it kinda surprising that there is no setting to change the format of the date separate from the actual locale, which seems like a missed opportunity to me.
I'll file an issue about this to have it properly tracked.

@timvink
Copy link
Owner

timvink commented Feb 6, 2022

Thanks, you're right. It's related to the bug #79 , this is actually a Dutch timezone ordering.

Can you also change these lines?

28 November, 2019 # type: date (default)
28 November, 2019 13:57:28 # type: datetime

@Andre601
Copy link
Contributor Author

Andre601 commented Feb 6, 2022

Done

@timvink
Copy link
Owner

timvink commented Feb 6, 2022

Thanks! ❤️

@timvink timvink merged commit ca3e191 into timvink:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants