batch of small fixes and enhancements - late december'2024 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ockchip64 in upstream Armbian Signed-off-by: Ricardo Pardini <[email protected]>
- use inventory and output into json matrix Signed-off-by: Ricardo Pardini <[email protected]>
- introduce `hook_template_vars` dict (KEY=value) - with `HOOK_VERSION`, `HOOK_KERNEL_IMAGE` et al directly - remove the nameref from `build_hook_linuxkit_container`, instead set directly in the `hook_template_vars` dict (`HOOK_CONTAINER_BOOTKIT_IMAGE` et al) - derive the envsubst dollar-prefixed list and the actual vars from the dict - before: refer to the variable 3 times (settage, export, dollar) - after: add variable to dict (once) Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
Signed-off-by: Ricardo Pardini <[email protected]>
- dead code for `kernel_id_to_use` (we're using USE_KERNEL_ID directly) - quoting for the `USE_LATEST_BUILT_KERNEL` case Signed-off-by: Ricardo Pardini <[email protected]>
- ensures bash sanity and future maintainability Signed-off-by: Ricardo Pardini <[email protected]>
- turns out `$(uname -m)` can return `arm64` as well as `aarch64` Signed-off-by: Ricardo Pardini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inventory: drop rk3588 flavor, as that has been merged with generic rockchip64 in upstream Armbian
Signed-off-by: Ricardo Pardini [email protected]
ci/inventory: de-hardcode list of flavors for which .iso's are built
Signed-off-by: Ricardo Pardini [email protected]
bash: make the lk yaml templating via envsubst a bit less tedious
hook_template_varsdict (KEY=value)HOOK_VERSION,HOOK_KERNEL_IMAGEet al directlybuild_hook_linuxkit_container, instead set directly in thehook_template_varsdict (HOOK_CONTAINER_BOOTKIT_IMAGEet al)Signed-off-by: Ricardo Pardini [email protected]
linuxkit: support builds using MacOS (amd64/arm64)
Signed-off-by: Ricardo Pardini [email protected]
linuxkit: bump 1.5.0 -> 1.5.2
Signed-off-by: Ricardo Pardini [email protected]
bash: squash some shellcheck warnings
kernel_id_to_use(we're using USE_KERNEL_ID directly)USE_LATEST_BUILT_KERNELcaseSigned-off-by: Ricardo Pardini [email protected]
ci/gha: run shellcheck before preparing the JSON matrix
Signed-off-by: Ricardo Pardini [email protected]
bash: better support for building under Apple Silicon aarch64/arm64
$(uname -m)can returnarm64as well asaarch64Signed-off-by: Ricardo Pardini [email protected]