Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use netip in netdever API #8

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Use netip in netdever API #8

merged 2 commits into from
Dec 4, 2023

Conversation

soypat
Copy link
Contributor

@soypat soypat commented Nov 29, 2023

netip is a full rework of the net.IP type. It solves a wide variety of issues with the net.IP type. It is well documented here.

Copy link
Contributor

@scottfeldman scottfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will need corresponding changes in tinygo-driver's netdever interface.

netdev.go Outdated Show resolved Hide resolved
@scottfeldman
Copy link
Contributor

Added matching PR tinygo-org/drivers#622 to change existing drivers to match netdever interface changes to netip.

@deadprogram
Copy link
Member

Thanks for working on this @soypat and for review @scottfeldman now merging.

@deadprogram deadprogram merged commit 1c04b2c into main Dec 4, 2023
@deadprogram deadprogram deleted the netdev-refurbish branch December 4, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants