Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make v1 pool refresh optional, same as v2 pools. #59

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

guanzo
Copy link
Contributor

@guanzo guanzo commented Jan 13, 2023

No description provided.

Copy link
Contributor

@gokselcoban gokselcoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @guanzo, thank you for your contribution. It is very helpful.

This was on our TODO list but somehow I forgot to do it with V2 changes.

This repo uses black code formatter.
https://github.com/psf/black

Tests are failing because of the formatting. Do you have time to fix it?
After installing black, running black . or black <path/filename.py> will be enough.
https://github.com/tinymanorg/tinyman-py-sdk/actions/runs/3909557675/jobs/6683448549

tinyman/v1/pools.py Outdated Show resolved Hide resolved
@guanzo
Copy link
Contributor Author

guanzo commented Jan 13, 2023

Do you have time to fix it?

Yes, will get around to it today!

Copy link
Contributor

@gokselcoban gokselcoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, LGTM!

@gokselcoban gokselcoban merged commit 10cca38 into tinymanorg:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants