Fix other.test_emcc_print_file_name under windows. NFC (emscripten-co…

…re#17261)
tiran · Jun 18, 2022 · 854adf6 · 854adf6
1 parent 1706b8e
commit 854adf6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -508,6 +508,7 @@ jobs:
             other.test_embed_file_dup
             other.test_dot_a_all_contents_invalid
             other.test_emcc_print_search_dirs
+            other.test_emcc_print_file_name
             other.test_pkg_config*"
       # Run a single websockify-based test to ensure it works on windows.
       - run-tests:

diff --git a/tests/test_other.py b/tests/test_other.py
@@ -626,7 +626,8 @@ def test_emcc_print_search_dirs(self):
   def test_emcc_print_file_name(self):
     self.run_process([EMBUILDER, 'build', 'libc'])
     output = self.run_process([EMCC, '-print-file-name=libc.a'], stdout=PIPE).stdout
-    self.assertContained(shared.Cache.get_lib_name('libc.a'), output)
+    filename = Path(output)
+    self.assertContained(shared.Cache.get_lib_name('libc.a'), str(filename))
 
   def test_emar_em_config_flag(self):
     # Test that the --em-config flag is accepted but not passed down do llvm-ar.