Prefer Dir over Rake::FileList
#185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes all the CI inconsistencies. Fixes: titusfortner#184 Signed-off-by: Utkarsh Gupta <[email protected]>
Signed-off-by: Utkarsh Gupta <[email protected]>
utkarsh2102
force-pushed
the
use-dir-instead
branch
from
ed7a4e7 to
0885e40
Compare
|
@utkarsh2102 Awesome! Thank you very much. Closes #184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kapoorlakshya 👋🏻
As discussed in #184, here's the PR fixing CI inconsistencies! 💯
This also updates the version of
RuboCop::Packagingto v0.5.0.Hopefully everything is in order and good to go! 💪🏻
Signed-off-by: Utkarsh Gupta <[email protected]>