Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring request #25

Open
egandro opened this issue May 8, 2024 · 5 comments
Open

refactoring request #25

egandro opened this issue May 8, 2024 · 5 comments

Comments

@egandro
Copy link

egandro commented May 8, 2024

Great work!

I would like to make a suggestion.

Can we refactor main.go and have a main.go (having a main and flags) and a pbsclient.go and add C-linkage on top of this?

My intention is to make this library work as foundation to other software e.g. an electron client.

Go is a very nice language for that! Rust is such a pain in butt to add C level linkage to this.

Please confirm that you love the idea and I will to the work.

Thx.

@tizbac
Copy link
Owner

tizbac commented May 9, 2024 via email

@egandro
Copy link
Author

egandro commented May 9, 2024

Also - related to that.

If we go library, can we go LGPL for the License?

I think that makes sense.

@tizbac
Copy link
Owner

tizbac commented May 9, 2024

Ok for me but i have to ask who has contributed to sign that change will take some time

@egandro
Copy link
Author

egandro commented May 14, 2024

So everybody in for the LGPL change?

@scheibling
Copy link

scheibling commented May 18, 2024

Having this code to use as a library would be amazing. We're in the process of building a custom PXAR library (reading through your code has been a huge help in figuring some parts out), only for the archive format though and not the communication with PBS.

The plan is to offer a more consistent/easy interface for reading/writing data to/from PXAR Archives from disk or data alike, if you wanna use the library or copy out some code to use that might make save some time for you. It's gonna be released under the LGPL as well

If everything goes as planned, we'll have an early version released in 1-2 weeks. We have written a lot more specific docs about the file format as well and will try to talk to Maurer about extending the official docs

Edit: A bit later than expected, but now we have some initial code along with some better documentation on the format. This is currently only for the PXAR and PCAT1-formats, and not the PBS communication https://github.com/scheiblingco/go-pxar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants