Add json configuration ad email notification #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During backup there are multiple operations that may fail which were ignored. This commit begins to address this issue by forwarding the errors back to the main function that can tell the user if the backup was successful or not. Since `panic()` stops the execution of the program, by returning the error to upper levels we can enable more sophisticated notification modes without worring updating every single function that may fail.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all, geat project, I just made some small additions to the program which are not exaustive and are considered to be just a small step towards a better project. Here's what I did:
JSON configuration
I added the possibility to pass all the configuration as a json file. This comes a long a very simple configuration management, which can be used as a foundation for further developments.
removed some panic()
Calling the
panic()function, actually stops the execution of the program, wherever it is. This makes difficult to correctly handle errors (more infos in the commit message oface6224fa8311850392be23e06f25fb80be8950b)mail notifications
backups are often an automated and unsupervised task so it is useful some sort of notification in order to know if the backup was successful.
Please consider (and review) this PR, I'm willing to discuss every aspect of it.