connect-redis not working with latest version of node-redis client (https://github.com/redis/node-redis)

[rukmanidevi-bh]

This code snippet uses latest version of conenct redis and node-redis and req.session is setting undefined when opening app in browser.
`import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const express = require('express');
const session = require('express-session');
const app = express();
import { createClient } from 'redis';
const redisStore = require('connect-redis')(session);

const port = process.env.PORT || 8030;
const config= {
"host":"127.0.0.1",
"port":6379,
"username":"",
"password":"test"
};

async function setupsession(){
const client = createClient({ url: 'redis://default:[email protected]:6379'});

client.on('error', (err) => console.log('Redis Client Error', err));

await client.connect();

app.use(session({
secret: 'top_secrect_react_app_hub',
name: 'local.cookie',
proxy: true,
resave: false,
saveUninitialized: true,
cookie: {
secure: true,
httpOnly: true
},
store: new redisStore({ client: client }),
}
));

await client.set('age', '31');
await client.set('field1', 'value1');
 await client.set( 'field2', 'value2');
 await client.hSet('myhash', 'field1', "Hello");

const val=await client.hGetAll('myhash');
const value = await client.get('field1');
console.log(value);
console.log(val);
const [ping, get, quit] = await Promise.all([
client.ping(),
client.get('key1'),
//client.quit()
]); // ['PONG', null, 'OK']
console.log(ping,get,quit);
try {
await client.get('key');
} catch (err) {
// ClosedClient Error
console.log(err);
}
}

app.get('/', function (req, res) {
	 req.session.test="new";
		   req.session.save();
		   res.send('server started');
		  
	
});
app.get('/rbac', function (req, res) {
		   req.session.expiresOn = 'test stored';
	
});
setupsession();

var server = app.listen(port, function() {
console.log(Server started on PORT ${port});

});`

[basaran]

Ran into the same issue, just now. If you had installed the @next version of node-redis, add this legacyMode to your client config:

const client = createClient({
    legacyMode: true
});

https://github.com/redis/node-redis/blob/master/docs/v3-to-v4.md

[rukmanidevi-bh]

@basaran are able to connect to Redis 6 instance with username and password in legacy mode. Because the reason i upgraded to @next version of node-redis is that old version send only password in auth , which doesn't support ACL in Redis 6 version.

[huineng]

the legacyMode: true currently allows for using the new "redis": "^4.0.0" but without that flag, it's indeed not working

The client successfully connects to redis , but loading or using session storage is not working
Difficult to debug but i have seen errors like this

TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received an instance of Array
        at new NodeError (node:internal/errors:371:5)
        at _write (node:internal/streams/writable:312:13)
        at TLSSocket.Writable.write (node:internal/streams/writable:334:10)
        at RedisSocket.writeCommand (myapp/node_modules/@node-redis/client/dist/lib/client/socket.js:57:130)
        at Commander._RedisClient_tick (myapp/node_modules/@node-redis/client/dist/lib/client/index.js:415:64)
        at Commander._RedisClient_sendCommand (myapp/node_modules/@node-redis/client/dist/lib/client/index.js:396:82)
        at Commander.commandsExecutor (myapp/node_modules/@node-redis/client/dist/lib/client/index.js:160:154)
        at Commander.BaseClass.<computed> [as set] (myapp/node_modules/@node-redis/client/dist/lib/commander.js:8:29)
        at RedisStore.set (myapp/node_modules/connect-redis/lib/connect-redis.js:65:21)
        at Session.save (myapp/node_modules/express-session/session/session.js:72:25) {
         code: 'ERR_INVALID_ARG_TYPE'
    }

and

message: Promise {
    <rejected> ReplyError: ERR Protocol error: expected '$', got ' '
        at parseError (myapp/node_modules/redis-parser/lib/parser.js:179:12)
        at parseType (myapp/node_modules/redis-parser/lib/parser.js:302:14)
  },

I only use redis for session storage

thanks

[abhijoshi2k]

Any estimate when #337 will be merged?

[wavded]

I cannot recommend using Redis v4 at this time as it is not interoperable with Redis v3 (its legacyMode feature is broken and has many bugs at the moment). It is also not interoperable with ioredis and redis-mock which are used by others. For now, I have updated the documentation to install redis@v3 for the time being.

redis/node-redis#1765

[salaadas]

I also noticed that the maxAge isn't working right, I set to 10 years but it is only set for several months

[wavded]

Support for Redis V4 now exists through the legacyMode option.

[wavded]

I am removing the legacyMode requirement in the next major version of this package. If you want to try it you can npm install connect-redis@next in your projects:

Migration guide in this PR: #377

[wavded]

v7.0.0 has been released, closing