Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when nested POST variables contained excessive characters #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shybovycha
Copy link

We faced a pity situation when the form

<form ...>
<input name="question[options[a]]" />
</form>

being submit returned the object

{
  question: {
    options: {
      'a]': 'the value'
    }
  }
}

Found the bug when excessive elements were merged into the object, fixed simply removing them from the parts array being merged.

Note: this is a major-priority bugfix as it may break much functionality!

@tj
Copy link
Owner

tj commented Jan 18, 2013

tests please!

@shybovycha
Copy link
Author

tested on our real project =) yet successful =)

@tj
Copy link
Owner

tj commented Jan 28, 2013

that doesn't count :p

@shybovycha
Copy link
Author

Okay, what exactly do you mean saying tests please! ?

Damn! Just now read the word tests ... First N times were read as test... Sorry 😝 Anyway, what do you mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants