Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az-storage: add page #6647

Merged
merged 3 commits into from
Oct 1, 2021
Merged

az-storage: add page #6647

merged 3 commits into from
Oct 1, 2021

Conversation

WhileLoop
Copy link
Contributor

@WhileLoop WhileLoop commented Oct 1, 2021

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Copy link
Member

@blueskyson blueskyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only a little suggestion, move az storage account create to the first example because it seems to be a beginning step of this application.

@blueskyson blueskyson added the new command Issues requesting creation of a new page. label Oct 1, 2021
@blueskyson blueskyson changed the title add page: az storage add page: az-storage Oct 1, 2021
@blueskyson blueskyson changed the title add page: az-storage az-storage: add page Oct 1, 2021
pages/common/az-storage.md Outdated Show resolved Hide resolved
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @WhileLoop!

@sbrl sbrl merged commit bc44dfb into tldr-pages:main Oct 1, 2021
@WhileLoop WhileLoop deleted the az-storage branch October 1, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants