Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks Log does not implement the new methods #596

Closed
terwey opened this issue Feb 1, 2024 · 0 comments
Closed

Callbacks Log does not implement the new methods #596

terwey opened this issue Feb 1, 2024 · 0 comments

Comments

@terwey
Copy link
Contributor

terwey commented Feb 1, 2024

The new methods for callbacks are not implemented in the LogHandler in tag v0.1.4

I am sure this was missed because of the following composition and thus the static assertion is moot.

// LogHandler is a callback handler that prints to the standard output.
type LogHandler struct {
SimpleHandler
}
var _ Handler = LogHandler{}

These methods are missing:

HandleLLMGenerateContentStart(ctx context.Context, ms []llms.MessageContent)
HandleLLMGenerateContentEnd(ctx context.Context, res *llms.ContentResponse)

HandleStreamingFunc(ctx context.Context, chunk []byte)

@tmc tmc closed this as completed in 9dc6ea7 Feb 4, 2024
tmc added a commit that referenced this issue Feb 4, 2024
Callbacks Log: Implement logging for text types, fixes #596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant