Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai: reflect max_token field deprecation #1013

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

tmc
Copy link
Owner

@tmc tmc commented Sep 12, 2024

The max_tokens field has been deprecated: https://platform.openai.com/docs/api-reference/chat/create#chat-create-max_tokens

I have not yet changed the high level API as that will require a bit more thought, but this changes the payload representation to not send this deprecated field. This is important for the o1 models which do not support that max_tokens.

@tmc tmc force-pushed the openai-max-token-reflection branch from 5dc5027 to 75c2ca4 Compare September 12, 2024 22:41
@tmc tmc enabled auto-merge (squash) September 12, 2024 22:41
@tmc tmc merged commit c578cf8 into main Sep 12, 2024
3 checks passed
@tmc tmc deleted the openai-max-token-reflection branch September 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant