chains: fix issue with overriding defaults in chainCallOption #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abirdcfly
approved these changes
Feb 23, 2024
mdelapenya
added a commit
to mdelapenya/langchaingo
that referenced
this pull request
Mar 6, 2024
* main: chains: fix add ignore StreamingFunc (tmc#639) Update huggingface.mdx chore: Pinning chroma-go ahead of major new release Clean up sequential_chain_example to make it a bit more readable (tmc#635) Fix llm_math_chain example (tmc#634) Update comments, bump example dependencies and clarify chain example (tmc#633) chains: fix issue with overriding defaults in chainCallOption (tmc#632) chains: add test with GoogleAI (tmc#628) Revert "googleai: fix options need add default value" (tmc#627) googleai: fix options need add default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #626
Fixes #603
Fixes #604
Fixes #594
This is a backwards compatible fix until we fix #626 for real.
Note that the workaround can now be removed in the GoogleAI chains test.