This example hangs if the JSON data is either marked as human or AI, it only works for me when marked as system #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it only works for me when marked as system
tmc
approved these changes
Mar 13, 2024
|
I'm not convinced that It happens (at least for me) when Ollama isn't responding with the correct format so we retry. After a couple of retries it seems to hang. Maybe a bit of prompt engineering or backtracking would improve things, but I'm surprised at well that we hang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example hangs if the JSON data is either marked as human or AI, it only works for me when marked as system. This PR makes it so the example no longer hangs.