-
-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llms/cloudflare: Implement Cloudflare Workers AI LLM #679
Conversation
@rajaiswal looking forward to this! can you get this over the line and mark it ready for review? |
@tmc I just need to add tests. What's the general acceptable test pattern here? I see some llms are spinning up a mock server, and some are testing against the real API with test tokens. Not sure which one to follow |
The short answer is that we haven't solidified and recommended an approach yet. Would love contributions to help shape that, but in the short term do what you feel is expedient and appropriate. |
fdc2da4
to
38decb3
Compare
@tmc PR is ready for review. Some unrelated files got touched when I ran linting and gofumpt, would you like me to revert those files back to their original state and isolate the linting only to my changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! No worries with the unrelated format fixes. Just a few small comments here but generally this looks like it's nearly good to go in!
Can you ensure that all introduced exported symbols (except those in internal packages) are commented?
@tmc this should be good to merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
PR Checklist
memory: add interfaces for X, Y
orutil: add whizzbang helpers
).Fixes #123
).golangci-lint
checks.This PR implements Cloudflare Workers AI LLM as documented here. Functionality is at parity with Langhain's Cloudflare Workers AI implementation.