Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openai: WithEmbeddingModel option is incorrectly designating the desired model to use for embedding #731

Merged
merged 2 commits into from
Mar 31, 2024
Merged

openai: WithEmbeddingModel option is incorrectly designating the desired model to use for embedding #731

merged 2 commits into from
Mar 31, 2024

Conversation

devalexandre
Copy link
Contributor

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

References a Issue #729

tmc
tmc reviewed Mar 31, 2024
View reviewed changes
llms/openai/internal/openaiclient/embeddings.go
@@ -34,13 +34,19 @@ type embeddingResponsePayload struct {

// nolint:lll
func (c *Client) createEmbedding(ctx context.Context, payload *embeddingPayload) (*embeddingResponsePayload, error) {
if c.baseURL == "" {
c.baseURL = defaultBaseURL
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not specific to this PR but I think this technically would be a data race if called concurrently. While this is pretty innocuous we should pass the data race detector's checks. -- Can you PR a change to add such a test and then change this to avoid triggering the race detector?

tmc
tmc reviewed Mar 31, 2024
View reviewed changes
llms/openai/internal/openaiclient/embeddings.go
c.baseURL = defaultBaseURL
}

if c.apiType == APITypeOpenAI {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like it merits a comment

tmc
tmc approved these changes Mar 31, 2024
View reviewed changes
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but see comment

@tmc tmc merged commit 05ab264 into tmc:main Mar 31, 2024
3 checks passed
@tmc tmc mentioned this pull request Mar 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmc tmc tmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devalexandre @tmc