Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update google/generative-ai-go to v0.14.0 #901

Closed
wants to merge 1 commit into from
Closed

Conversation

JckHoe
Copy link
Contributor

@JckHoe JckHoe commented Jun 17, 2024

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions. (only version bump and minor change)
  • Passes all golangci-lint checks.

bumping google-ai dependencies to latest 0.14.0

@JckHoe
Copy link
Contributor Author

JckHoe commented Jun 17, 2024

the changes are for

panic: interface conversion: interface {} is []string, not []interface {}

When running the example for tool calls using google-ai

removed the converting slice of interface as it is now already slice of string from the parameter required?

From the example

"required": []string{"location"},

https://github.com/tmc/langchaingo/blob/main/examples/googleai-tool-call-example/googleai-tool-call-example.go#L103

@wangjiancn
Copy link
Contributor

sry, i fix it in #903

@JckHoe
Copy link
Contributor Author

JckHoe commented Jun 18, 2024

@wangjiancn awesome, thanks!

@JckHoe JckHoe closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants