Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputparser: improve BooleanOutputParser #978

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

amitaifrey
Copy link
Contributor

@amitaifrey amitaifrey commented Aug 4, 2024

The BooleanOutputParser requests the LLM to respond with a boolean, and gives examples such as true or false. However, it only parsed respones that include YES or NO. This commits adds more values for parsing and changes the tests to fit them.

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • Describes the source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@amitaifrey amitaifrey force-pushed the improve-boolean-parser branch 3 times, most recently from 9f870f2 to 1ed2922 Compare August 4, 2024 15:34
The BooleanOutputParser requests the LLM to respond with a boolean,
and gives examples such as `true` or `false`. However, it only parsed
respones that include YES or NO. This commits adds more values for
parsing and changes the tests to fit them.
Copy link
Owner

@tmc tmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmc tmc merged commit ddb8293 into tmc:main Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants