Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test_capture_pane): use of double env #452

Merged
merged 2 commits into from
Nov 5, 2022

Conversation

zappolowski
Copy link
Contributor

This makes the test fail (at least for me) as it still won't start bash but my login-shell (which is not bash).

tests/test_pane.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #452 (5783026) into master (3c71322) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 5783026 differs from pull request most recent head b74e428. Consider uploading reports for the commit b74e428 to get more accurate results

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   87.44%   87.46%   +0.02%     
==========================================
  Files          20       20              
  Lines        1800     1803       +3     
  Branches      280      280              
==========================================
+ Hits         1574     1577       +3     
  Misses        154      154              
  Partials       72       72              
Impacted Files Coverage Δ
tests/test_pane.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This makes the test fail (at least for me) as it still won't start bash
but my login-shell (which is not bash).
@tony tony mentioned this pull request Nov 5, 2022
@tony tony merged commit b2ed108 into tmux-python:master Nov 5, 2022
@zappolowski zappolowski deleted the fix/double-env branch November 5, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants