Fix: remove side on condition simplification

tobymao · Jun 19, 2023 · 6945b28 · 6945b28
1 parent 2f43629
commit 6945b28
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/sqlglot/optimizer/simplify.py b/sqlglot/optimizer/simplify.py
@@ -408,9 +408,14 @@ def remove_where_true(expression):
         if always_true(where.this):
             where.parent.set("where", None)
     for join in expression.find_all(exp.Join):
-        if always_true(join.args.get("on")):
-            join.set("kind", "CROSS")
+        if (
+            always_true(join.args.get("on"))
+            and not join.args.get("using")
+            and not join.args.get("method")
+        ):
             join.set("on", None)
+            join.set("side", None)
+            join.set("kind", "CROSS")
 
 
 def always_true(expression):

diff --git a/tests/fixtures/optimizer/simplify.sql b/tests/fixtures/optimizer/simplify.sql
@@ -240,6 +240,12 @@ A AND B AND C;
 SELECT x WHERE TRUE;
 SELECT x;
 
+SELECT x FROM y LEFT JOIN z ON TRUE;
+SELECT x FROM y CROSS JOIN z;
+
+SELECT x FROM y JOIN z USING (x);
+SELECT x FROM y JOIN z USING (x);
+
 --------------------------------------
 -- Parenthesis removal
 --------------------------------------