Fix(snowflake): better support for LISTAGG (#2147)

tobymao · Sep 3, 2023 · 7b589ae · 7b589ae
1 parent 5df9b5f
commit 7b589ae
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/sqlglot/dialects/snowflake.py b/sqlglot/dialects/snowflake.py
@@ -242,6 +242,7 @@ class Parser(parser.Parser):
             "DATEDIFF": _parse_datediff,
             "DIV0": _div0_to_if,
             "IFF": exp.If.from_arg_list,
+            "LISTAGG": exp.GroupConcat.from_arg_list,
             "NULLIFZERO": _nullifzero_to_if,
             "OBJECT_CONSTRUCT": _parse_object_construct,
             "REGEXP_REPLACE": _parse_regexp_replace,
@@ -361,6 +362,7 @@ class Generator(generator.Generator):
             exp.DataType: _datatype_sql,
             exp.DayOfWeek: rename_func("DAYOFWEEK"),
             exp.Extract: rename_func("DATE_PART"),
+            exp.GroupConcat: rename_func("LISTAGG"),
             exp.If: rename_func("IFF"),
             exp.LogicalAnd: rename_func("BOOLAND_AGG"),
             exp.LogicalOr: rename_func("BOOLOR_AGG"),

diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -4449,7 +4449,7 @@ class Greatest(Func):
     is_var_len_args = True
 
 
-class GroupConcat(Func):
+class GroupConcat(AggFunc):
     arg_types = {"this": True, "separator": False}
 
 

diff --git a/tests/dialects/test_snowflake.py b/tests/dialects/test_snowflake.py
@@ -36,6 +36,7 @@ def test_snowflake(self):
             },
         )
 
+        self.validate_identity("LISTAGG(data['some_field'], ',')")
         self.validate_identity("WEEKOFYEAR(tstamp)")
         self.validate_identity("SELECT SUM(amount) FROM mytable GROUP BY ALL")
         self.validate_identity("WITH x AS (SELECT 1 AS foo) SELECT foo FROM IDENTIFIER('x')")