Fix: coalesce simplify window func

tobymao · Aug 14, 2023 · 8affeff · 8affeff
1 parent 2e73a4f
commit 8affeff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -3313,7 +3313,7 @@ class Pivot(Expression):
     }
 
 
-class Window(Expression):
+class Window(Condition):
     arg_types = {
         "this": True,
         "partition_by": False,

diff --git a/tests/fixtures/optimizer/simplify.sql b/tests/fixtures/optimizer/simplify.sql
@@ -645,6 +645,9 @@ x = 1 OR x IS NULL;
 COALESCE(x, 1) IS NULL;
 FALSE;
 
+COALESCE(ROW() OVER (), 1) = 1;
+ROW() OVER () = 1 OR ROW() OVER () IS NULL;
+
 --------------------------------------
 -- CONCAT
 --------------------------------------
-Original file line number
+Diff line change
@@ Expand Up / @@ -645,6 +645,9 @@ x = 1 OR x IS NULL; @@
     COALESCE(x, 1) IS NULL;
     FALSE;
+    COALESCE(ROW() OVER (), 1) = 1;
+    ROW() OVER () = 1 OR ROW() OVER () IS NULL;
     --------------------------------------
     -- CONCAT
     --------------------------------------
@@ Expand Down @@