Fix: binary_double/float types closes #1543

tobymao · May 4, 2023 · 8ebba48 · 8ebba48
1 parent f21abb7
commit 8ebba48
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/sqlglot/dialects/oracle.py b/sqlglot/dialects/oracle.py
@@ -173,6 +173,8 @@ class Tokenizer(tokens.Tokenizer):
         KEYWORDS = {
             **tokens.Tokenizer.KEYWORDS,
             "(+)": TokenType.JOIN_MARKER,
+            "BINARY_DOUBLE": TokenType.DOUBLE,
+            "BINARY_FLOAT": TokenType.FLOAT,
             "COLUMNS": TokenType.COLUMN,
             "MATCH_RECOGNIZE": TokenType.MATCH_RECOGNIZE,
             "MINUS": TokenType.EXCEPT,

diff --git a/tests/dialects/test_oracle.py b/tests/dialects/test_oracle.py
@@ -29,6 +29,21 @@ def test_oracle(self):
             },
         )
 
+        self.validate_all(
+            "x::binary_double",
+            write={
+                "oracle": "CAST(x AS DOUBLE PRECISION)",
+                "": "CAST(x AS DOUBLE)",
+            },
+        )
+        self.validate_all(
+            "x::binary_float",
+            write={
+                "oracle": "CAST(x AS FLOAT)",
+                "": "CAST(x AS FLOAT)",
+            },
+        )
+
     def test_join_marker(self):
         self.validate_identity("SELECT e1.x, e2.x FROM e e1, e e2 WHERE e1.y (+) = e2.y")
         self.validate_identity("SELECT e1.x, e2.x FROM e e1, e e2 WHERE e1.y = e2.y (+)")