Fix!: store expressions in Limit.expression when using builder (#2249)

* Fix!: store expressions in Limit.expression when using builder * Rename wrap_arg to into_arg
tobymao · Sep 17, 2023 · 8ebbfe2 · 8ebbfe2
1 parent ff19f4c
commit 8ebbfe2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/sqlglot/expressions.py b/sqlglot/expressions.py
@@ -2861,6 +2861,7 @@ def limit(
             prefix="LIMIT",
             dialect=dialect,
             copy=copy,
+            into_arg="expression",
             **opts,
         )
 
@@ -5130,10 +5131,11 @@ def _apply_builder(
     prefix=None,
     into=None,
     dialect=None,
+    into_arg="this",
     **opts,
 ):
     if _is_wrong_expression(expression, into):
-        expression = into(this=expression)
+        expression = into(**{into_arg: expression})
     instance = maybe_copy(instance, copy)
     expression = maybe_parse(
         sql_or_expression=expression,

diff --git a/tests/dialects/test_duckdb.py b/tests/dialects/test_duckdb.py
@@ -6,6 +6,11 @@ class TestDuckDB(Validator):
     dialect = "duckdb"
 
     def test_duckdb(self):
+        self.assertEqual(
+            parse_one("select * from t limit (select 5)").sql(dialect="duckdb"),
+            exp.select("*").from_("t").limit(exp.select("5").subquery()).sql(dialect="duckdb"),
+        )
+
         for join_type in ("SEMI", "ANTI"):
             exists = "EXISTS" if join_type == "SEMI" else "NOT EXISTS"