Fix(optimizer): dont simplify parens with multiple predicates closes #…

…2131
tobymao · Aug 31, 2023 · 999a950 · 999a950
1 parent 632ad59
commit 999a950
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/sqlglot/optimizer/simplify.py b/sqlglot/optimizer/simplify.py
@@ -431,9 +431,9 @@ def simplify_parens(expression):
 
     if not isinstance(this, exp.Select) and (
         not isinstance(parent, (exp.Condition, exp.Binary))
-        or isinstance(this, exp.Predicate)
         or isinstance(parent, exp.Paren)
         or not isinstance(this, exp.Binary)
+        or (isinstance(this, exp.Predicate) and not isinstance(parent, exp.Predicate))
         or (isinstance(this, exp.Add) and isinstance(parent, exp.Add))
         or (isinstance(this, exp.Mul) and isinstance(parent, exp.Mul))
         or (isinstance(this, exp.Mul) and isinstance(parent, (exp.Add, exp.Sub)))

diff --git a/tests/fixtures/optimizer/simplify.sql b/tests/fixtures/optimizer/simplify.sql
@@ -291,6 +291,9 @@ x = y AND z;
 x * (1 - y);
 x * (1 - y);
 
+(((x % 20) = 0) = TRUE);
+((x % 20) = 0) = TRUE;
+
 --------------------------------------
 -- Literals
 --------------------------------------