Feat(duckdb): support TO_JSON (#1803)

* Feat(duckdb): support TO_JSON * remove type logic
tobymao · Jun 19, 2023 · a2bf084 · a2bf084
1 parent 4da37aa
commit a2bf084
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/sqlglot/dialects/duckdb.py b/sqlglot/dialects/duckdb.py
@@ -85,6 +85,11 @@ def _regexp_extract_sql(self: generator.Generator, expression: exp.RegexpExtract
     )
 
 
+def _json_format_sql(self: generator.Generator, expression: exp.JSONFormat) -> str:
+    sql = self.func("TO_JSON", expression.this, expression.args.get("options"))
+    return f"CAST({sql} AS TEXT)"
+
+
 class DuckDB(Dialect):
     NULL_ORDERING = "nulls_are_last"
 
@@ -195,6 +200,7 @@ class Generator(generator.Generator):
             exp.IntDiv: lambda self, e: self.binary(e, "//"),
             exp.JSONExtract: arrow_json_extract_sql,
             exp.JSONExtractScalar: arrow_json_extract_scalar_sql,
+            exp.JSONFormat: _json_format_sql,
             exp.JSONBExtract: arrow_json_extract_sql,
             exp.JSONBExtractScalar: arrow_json_extract_scalar_sql,
             exp.LogicalOr: rename_func("BOOL_OR"),

diff --git a/tests/dialects/test_bigquery.py b/tests/dialects/test_bigquery.py
@@ -491,6 +491,7 @@ def test_bigquery(self):
             read={"bigquery": "TO_JSON_STRING(x)"},
             write={
                 "bigquery": "TO_JSON_STRING(x)",
+                "duckdb": "CAST(TO_JSON(x) AS TEXT)",
                 "presto": "JSON_FORMAT(x)",
                 "spark": "TO_JSON(x)",
             },

diff --git a/tests/dialects/test_presto.py b/tests/dialects/test_presto.py
@@ -665,6 +665,7 @@ def test_presto(self):
             },
             write={
                 "bigquery": "TO_JSON_STRING(x)",
+                "duckdb": "CAST(TO_JSON(x) AS TEXT)",
                 "presto": "JSON_FORMAT(x)",
                 "spark": "TO_JSON(x)",
             },
@@ -674,6 +675,7 @@ def test_presto(self):
             "JSON_FORMAT(JSON 'x')",
             write={
                 "bigquery": "TO_JSON_STRING(CAST('x' AS JSON))",
+                "duckdb": "CAST(TO_JSON(CAST('x' AS JSON)) AS TEXT)",
                 "presto": "JSON_FORMAT(CAST('x' AS JSON))",
                 "spark": "TO_JSON('x')",
             },