Fix: array_join -> concat_ws closes #1558

tobymao · May 5, 2023 · ac60698 · ac60698
1 parent 951d407
commit ac60698
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/sqlglot/dialects/hive.py b/sqlglot/dialects/hive.py
@@ -304,6 +304,7 @@ class Generator(generator.Generator):
             exp.Property: _property_sql,
             exp.ApproxDistinct: approx_count_distinct_sql,
             exp.ArrayConcat: rename_func("CONCAT"),
+            exp.ArrayJoin: lambda self, e: self.func("CONCAT_WS", e.expression, e.this),
             exp.ArraySize: rename_func("SIZE"),
             exp.ArraySort: _array_sort_sql,
             exp.With: no_recursive_cte_sql,

diff --git a/sqlglot/dialects/spark2.py b/sqlglot/dialects/spark2.py
@@ -204,6 +204,7 @@ class Generator(Hive.Generator):
             exp.WeekOfYear: rename_func("WEEKOFYEAR"),
             exp.AtTimeZone: lambda self, e: f"FROM_UTC_TIMESTAMP({self.sql(e, 'this')}, {self.sql(e, 'zone')})",
         }
+        TRANSFORMS.pop(exp.ArrayJoin)
         TRANSFORMS.pop(exp.ArraySort)
         TRANSFORMS.pop(exp.ILike)
 

diff --git a/tests/dialects/test_presto.py b/tests/dialects/test_presto.py
@@ -105,6 +105,13 @@ def test_regex(self):
                 "spark": "SIZE(x)",
             },
         )
+        self.validate_all(
+            "ARRAY_JOIN(x, '-', 'a')",
+            write={
+                "hive": "CONCAT_WS('-', x)",
+                "spark": "ARRAY_JOIN(x, '-', 'a')",
+            },
+        )
 
     def test_interval_plural_to_singular(self):
         # Microseconds, weeks and quarters are not supported in Presto/Trino INTERVAL literals