Feat(postgres): add MONEY type, revert in Spark to use DECIMAL(15, 4)

tobymao · Jul 6, 2023 · fafccf5 · fafccf5 · georgesittas · Jul 6, 2023
1 parent 2ab8887
commit fafccf5
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/sqlglot/dialects/postgres.py b/sqlglot/dialects/postgres.py
@@ -263,6 +263,7 @@ class Tokenizer(tokens.Tokenizer):
             "DO": TokenType.COMMAND,
             "HSTORE": TokenType.HSTORE,
             "JSONB": TokenType.JSONB,
+            "MONEY": TokenType.MONEY,
             "REFRESH": TokenType.COMMAND,
             "REINDEX": TokenType.COMMAND,
             "RESET": TokenType.COMMAND,

diff --git a/sqlglot/dialects/spark.py b/sqlglot/dialects/spark.py
@@ -43,8 +43,7 @@ class Parser(Spark2.Parser):
     class Generator(Spark2.Generator):
         TYPE_MAPPING = {
             **Spark2.Generator.TYPE_MAPPING,
-            # https://stackoverflow.com/a/224866
-            exp.DataType.Type.MONEY: "DECIMAL(19, 4)",
+            exp.DataType.Type.MONEY: "DECIMAL(15, 4)",
             exp.DataType.Type.SMALLMONEY: "DECIMAL(6, 4)",
             exp.DataType.Type.UNIQUEIDENTIFIER: "STRING",
         }

diff --git a/tests/dialects/test_postgres.py b/tests/dialects/test_postgres.py
@@ -121,6 +121,7 @@ def test_array_offset(self, logger):
         )
 
     def test_postgres(self):
+        self.validate_identity("CAST(x AS MONEY)")
         self.validate_identity("CAST(x AS INT4RANGE)")
         self.validate_identity("CAST(x AS INT4MULTIRANGE)")
         self.validate_identity("CAST(x AS INT8RANGE)")

diff --git a/tests/dialects/test_tsql.py b/tests/dialects/test_tsql.py
@@ -232,7 +232,7 @@ def test_types_decimals(self):
         self.validate_all(
             "CAST(x as MONEY)",
             write={
-                "spark": "CAST(x AS DECIMAL(19, 4))",
+                "spark": "CAST(x AS DECIMAL(15, 4))",
                 "tsql": "CAST(x AS MONEY)",
             },
         )