Fix: use preprocess instead of expanding transform dicts BREAKING #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
May 3, 2023
|
can you delete the constants in transform.py? |
|
Yeah.. Note that this will then be a breaking change. |
crericha
approved these changes
May 3, 2023
I agree. I followed the pattern from the redshift dialect, without knowing there was potential for collision. The new format in this PR is much clearer and mistake proof. |
georgesittas
changed the title
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
…bymao#1525) * Fix: use preprocess instead of expanding transform dicts * Formatting * Remove transform variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up #1524.
@tobymao I think we need to stop using the
**transforms.SOME_TRANSFORMpattern, because it can easily lead to bugs in the future. For example, prior to Chris' PR we had the following entry in theTRANSFORMSmap of bigquery:This would cause the
**transforms.ELIMINATE_DISTINCT_ONto be overridden and it's tricky to spot right away.cc: @crericha