Fix(oracle): set post_tablesample_alias=True to fix alias parsing #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
May 4, 2023
| @@ -426,29 +426,18 @@ def test_null_treatment(self): | |||
| def test_sample(self): | |||
There was a problem hiding this comment.
We used to convert SAMPLE to TABLESAMPLE, which are synonymous in Snowflake:
SAMPLE and TABLESAMPLE are synonymous and can be used interchangeably.
With the change in the parser related to kind (see _parse_table_sample), we now actually use whatever the token's text was, so I adapted these tests accordingly.
tobymao
approved these changes
May 4, 2023
georgesittas
force-pushed
the
jo/oracle_tablesample
branch
from
cb0c982 to
e1d791e
Compare
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
…bymao#1548) * Fix(oracle): set post_tablesample_alias=True to fix alias parsing * Fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1541