Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[BREAKING]: simplify from to one expression and auto expand multi … #1620

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix[BREAKING]: simplify from to one expression and auto expand multi … #1620

merged 1 commit into from
May 15, 2023

Conversation

tobymao
Copy link
Owner

@tobymao tobymao commented May 14, 2023

…table selects closes #1618

tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
266d02a
@tobymao tobymao force-pushed the toby/simplify_from branch from 79fa112 to 266d02a Compare May 15, 2023 03:21
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
b8fef06
@tobymao tobymao force-pushed the toby/simplify_from branch from 266d02a to b8fef06 Compare May 15, 2023 05:38
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
16adca9
@tobymao tobymao force-pushed the toby/simplify_from branch from b8fef06 to 16adca9 Compare May 15, 2023 05:40
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
5483f4c
@tobymao tobymao force-pushed the toby/simplify_from branch from 16adca9 to 5483f4c Compare May 15, 2023 05:42
@tobymao tobymao requested review from georgesittas and barakalon May 15, 2023 05:42
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
c0d8166
@tobymao tobymao force-pushed the toby/simplify_from branch from 5483f4c to c0d8166 Compare May 15, 2023 05:46
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
5bb2c78
@tobymao tobymao force-pushed the toby/simplify_from branch from c0d8166 to 5bb2c78 Compare May 15, 2023 06:14
georgesittas
georgesittas reviewed May 15, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like several sections have been greatly simplified. Awesome!

I left some comments.

sqlglot/dialects/bigquery.py Outdated Show resolved Hide resolved
sqlglot/dialects/bigquery.py Outdated Show resolved Hide resolved
sqlglot/dialects/bigquery.py Show resolved Hide resolved
sqlglot/dialects/bigquery.py Show resolved Hide resolved
sqlglot/expressions.py Outdated Show resolved Hide resolved
sqlglot/generator.py Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Show resolved Hide resolved
sqlglot/parser.py Outdated Show resolved Hide resolved
tests/test_parser.py Show resolved Hide resolved
sqlglot/optimizer/merge_subqueries.py Show resolved Hide resolved
@georgesittas
Copy link
Collaborator

FYI @tobymao I haven't checked the tpc changes in detail, just did a first pass on the PR. I'll try to check them later.

tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
6d7aa05
@tobymao tobymao force-pushed the toby/simplify_from branch from 5bb2c78 to 6d7aa05 Compare May 15, 2023 15:47
tobymao added a commit that referenced this pull request May 15, 2023
@tobymao
Fix: simplify from to a single expression closes #1620
4f0b4a1
@tobymao tobymao force-pushed the toby/simplify_from branch from 6d7aa05 to 4f0b4a1 Compare May 15, 2023 15:53
@tobymao tobymao force-pushed the toby/simplify_from branch from 4f0b4a1 to 080a9ed Compare May 15, 2023 15:56
georgesittas
georgesittas approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@tobymao tobymao merged commit 4833953 into main May 15, 2023
@tobymao tobymao deleted the toby/simplify_from branch May 15, 2023 16:03
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@tobymao @adrianisk
Fix: simplify from to a single expression closes tobymao#1620 (tobyma…
4d9346d 
…o#1620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

@barakalon barakalon Awaiting requested review from barakalon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect join parse?
2 participants
@tobymao @georgesittas