Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(bigquery): allow first part of table names to contain dashes #1624

Merged
merged 5 commits into from
May 15, 2023
Merged

Feat(bigquery): allow first part of table names to contain dashes #1624

merged 5 commits into from
May 15, 2023

Conversation

georgesittas
Copy link
Collaborator

tobymao
tobymao reviewed May 15, 2023
View reviewed changes
sqlglot/parser.py Outdated Show resolved Hide resolved
@georgesittas georgesittas merged commit a33112f into main May 15, 2023
@georgesittas georgesittas deleted the jo/bigquery_dashed_table_name branch May 15, 2023 16:29
adrianisk pushed a commit to adrianisk/sqlglot that referenced this pull request Jun 21, 2023
@georgesittas @adrianisk
Feat(bigquery): allow first part of table names to contain dashes (to…
350206e 
…bymao#1624)

* Feat(bigquery): allow first part of table names to contain dashes

* Move logic in bigquery

* simplify

* add test

* add more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myschkyna myschkyna myschkyna left review comments

@tobymao tobymao tobymao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgesittas @tobymao @myschkyna