Fix(postgres, redshift): use single string interval logic #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
May 18, 2023
| @@ -304,7 +304,7 @@ def _parse_date_part(self) -> exp.Expression: | |||
| return self.expression(exp.Extract, this=part, expression=value) | |||
|
|
|||
| class Generator(generator.Generator): | |||
| INTERVAL_ALLOWS_PLURAL_FORM = False | |||
There was a problem hiding this comment.
I tested against both engines (postgres, redshift), this was invalid as plural forms are allowed.
georgesittas
commented
May 18, 2023
| @@ -1852,7 +1852,7 @@ def interval_sql(self, expression: exp.Interval) -> str: | |||
|
|
|||
| if self.SINGLE_STRING_INTERVAL: | |||
| this = expression.this.name if expression.this else "" | |||
| return f"INTERVAL '{this}{unit}'" | |||
| return f"INTERVAL '{this}{unit}'" if this else f"INTERVAL{unit}" | |||
There was a problem hiding this comment.
Needed because we can have value::interval day, which would be transpiled to cast(value as interval ' day'), but it should be transpiled to cast(value as interval day).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1649