Fix(redshift): handle VALUES clause more robustly #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
May 18, 2023
| @@ -181,6 +181,16 @@ def test_identity(self): | |||
| ) | |||
|
|
|||
| def test_values(self): | |||
| self.validate_all( | |||
| "SELECT * FROM (VALUES (1, 2)) AS t", | |||
There was a problem hiding this comment.
This would previously cause an error if we were to transpile it to redshift:
for value, column_name in zip(row, expression.args["alias"].args["columns"])
TypeError: 'NoneType' object is not iterable
georgesittas
commented
May 18, 2023
| write={"redshift": "SELECT * FROM (SELECT 1, 2) AS t"}, | ||
| ) | ||
| self.validate_all( | ||
| "SELECT * FROM (VALUES (1)) AS t1(id) CROSS JOIN (VALUES (1)) AS t2(id)", |
There was a problem hiding this comment.
Probably a rare use case of VALUES, but thought I'd include it anyway. We weren't removing the second VALUES clause because only exp.From was checked as a possible parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @eakmanrq