Feat!(snowflake): normalize identifiers as uppercase #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
force-pushed
the
snowflake
branch
7 times, most recently
from
d14f9b8 to
c884363
Compare
georgesittas
changed the title
Co-authored-by: Jo <[email protected]>
tobymao
force-pushed
the
snowflake
branch
7 times, most recently
from
d4a9936 to
b0d6cc7
Compare
tobymao
commented
May 28, 2023
| expression: exp.Expression, dialect: DialectType = None | ||
| ) -> exp.Expression: | ||
| """ | ||
| Normalize all unquoted identifiers to either lower or upper case, depending on |
There was a problem hiding this comment.
cc @barakalon i've basically deleted this whole file
georgesittas
approved these changes
May 28, 2023
georgesittas
approved these changes
May 28, 2023
Co-authored-by: Jo <[email protected]>
adrianisk
pushed a commit
to adrianisk/sqlglot
that referenced
this pull request
Jun 21, 2023
* Feat!(snowflake): normalize identifiers as uppercase * fixup * fixup * Fix\!: lower aliases as well * Fix: maintain quotes in aliased names * Apply suggestions from code review Co-authored-by: Jo <[email protected]> * Simplify normalize_identifiers. * Update sqlglot/helper.py Co-authored-by: Jo <[email protected]> * default identify to true --------- Co-authored-by: George Sittas <[email protected]> Co-authored-by: Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.