-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor!: misc. improvements in formatting, type hints, dialect class variables #1750
Conversation
ab126f6
to
9a73d1b
Compare
Left one final question, but otherwise this PR is ready to go so feel free to merge. Note: after this is merged I can rebase in #1738 and move the |
34ff0d2
to
3d5573b
Compare
FYI I reverted the type hint change in the following commit because mypy was yelling Note that I changed the signature of |
…s variables (tobymao#1750) * Refactor!: misc. improvements in formatting, type hints, dialect class variables * Fix type * IS_BOOLEAN_ALLOWED -> IS_BOOL_ALLOWED * Comment fixup * Comment fixup * Type fixup * Add comments for dialect properties * More fixups * Fixup * Remove unnecessary call to validate expression * Remove unused code in Drill dialect * Style * Rebase type fixup
time_mapping
have been converted to uppercase for consistency, i.e.TIME_MAPPING
._Dialect
class.normalize_functions
arg has changed: nowFalse
means "don't normalize",True
is equiv. to"upper"
.IfNull
expression in favor of addingIFNULL
as a_sql_name
inCoalesce
.IS_BOOL
generator flag toIS_BOOL_ALLOWED
for clarity.validate_expression
return its argument, to improve composability.