Fix(bigquery): transpile explode projection to cross join unnest, clean up tests #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgesittas
commented
Jun 28, 2023
Comment on lines
-24
to
+45
| self.validate_identity("""SELECT * FROM UNNEST(ARRAY<STRUCT<x INT64>>[1, 2])""") | ||
| self.validate_identity("""SELECT * FROM UNNEST(ARRAY<STRUCT<x INT64>>[])""") |
There was a problem hiding this comment.
This was invalid BigQuery
georgesittas
commented
Jun 28, 2023
Comment on lines
+96
to
+101
| self.validate_all( | ||
| "WITH cte AS (SELECT [1, 2, 3] AS arr) SELECT col FROM cte CROSS JOIN UNNEST(arr) AS col", | ||
| read={ | ||
| "spark": "WITH cte AS (SELECT ARRAY(1, 2, 3) AS arr) SELECT EXPLODE(arr) FROM cte" | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Covers the newly added transform (explode -> cross join unnest).
georgesittas
commented
Jun 28, 2023
| self.validate_identity("ROLLBACK TRANSACTION") | ||
| self.validate_identity("CAST(x AS BIGNUMERIC)") | ||
|
|
||
| self.validate_identity("SELECT * FROM UNNEST([1]) WITH ORDINALITY") |
There was a problem hiding this comment.
Removed because WITH ORDINALITY is not valid in BigQuery. The valid form is WITH OFFSET and we're testing that just below this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left a few comments to highlight the changes made in this PR. The rest are just cosmetic changes.