Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add FLOAT(n) mappings to Hive #1896

Merged
merged 2 commits into from
Jul 7, 2023
Merged

feat: Add FLOAT(n) mappings to Hive #1896

merged 2 commits into from
Jul 7, 2023

Conversation

dmoore247
Copy link
Contributor

Hive/Spark2/Spark don't support FLOAT(n) data type.
This feat maps FLOAT(n) to float if n <= 32 and double otherwise

georgesittas
georgesittas reviewed Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a couple of comments.

The tests can probably be condensed a bit without losing coverage, but seems ok either way.

sqlglot/dialects/hive.py Show resolved Hide resolved
@georgesittas georgesittas merged commit 21246fb into tobymao:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoore247 @georgesittas