Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(clickhouse): add support for the logical xor function #1937

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Feat(clickhouse): add support for the logical xor function #1937

merged 2 commits into from
Jul 20, 2023

Conversation

georgesittas
Copy link
Collaborator

@georgesittas
Copy link
Collaborator Author

georgesittas commented Jul 20, 2023 •
edited
Loading

Seems like duckdb also supports xor(a, b), will add support for that shortly.

Actually, might do it in a followup PR because it's a bitwise xor, whereas this pr addresses a logical xor issue.

@georgesittas georgesittas merged commit 4b7e9f1 into main Jul 20, 2023
@georgesittas georgesittas deleted the jo/clickhouse_xor_function branch July 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xor function fails to parse with the clickhouse dialect
2 participants
@georgesittas @tobymao