Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(presto): add IPADDRESS/IPPREFIX data types #1965

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

roykoand
Copy link
Contributor

That's my first PR here, would be glad for any corrections.
Thank you!

Documentation: https://prestodb.io/docs/current/language/types.html?highlight=ipaddress#ipaddress

Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Feel free to add support for IPPREFIX too if you want.

tests/dialects/test_presto.py Outdated Show resolved Hide resolved
@roykoand roykoand changed the title Presto: Add IPADDRESS data type Presto: Add IPADDRESS/IPPFREXI data types Jul 27, 2023
@roykoand roykoand changed the title Presto: Add IPADDRESS/IPPFREXI data types Presto: Add IPADDRESS/IPPREFIX data types Jul 27, 2023
@georgesittas georgesittas changed the title Presto: Add IPADDRESS/IPPREFIX data types Feat(presto): add IPADDRESS/IPPREFIX data types Jul 27, 2023
@georgesittas georgesittas merged commit 5e641c2 into tobymao:main Jul 27, 2023
georgesittas pushed a commit that referenced this pull request Jul 27, 2023
* Presto: Add IPADDRESS data type

* Linter

* Presto: Add IPPREFIX data type

* Presto: Add IPPREFIX keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants