Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(optimizer): factor out pseudocolumns in qualify columns #1984

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

georgesittas
Copy link
Collaborator

Checking if dialect == "bigquery" in qualify_columns isn't very elegant. This PR abstracts that section away by introducing a Dialect attribute for storing pseudo-column names.

There are some other dialects that have pseudo-columns besides BigQuery, such as:

This attribute will make it easy to control what's expanded in SELECT * queries for them too, if ever needed.

cc: @z3z1ma

@tobymao tobymao merged commit 9e77c7b into main Jul 31, 2023
@tobymao tobymao deleted the jo/pseudocolumns branch July 31, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants