Refactor(optimizer): factor out pseudocolumns in qualify columns #1984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if
dialect == "bigquery"
inqualify_columns
isn't very elegant. This PR abstracts that section away by introducing aDialect
attribute for storing pseudo-column names.There are some other dialects that have pseudo-columns besides BigQuery, such as:
This attribute will make it easy to control what's expanded in
SELECT *
queries for them too, if ever needed.cc: @z3z1ma