Fix: improve comment handling for several expressions #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making a couple more additions to this... |
georgesittas
force-pushed
the
jo/comment_fixup
branch
from
0fe9867 to
d385946
Compare
tobymao
reviewed
Aug 9, 2023
| @@ -2338,7 +2341,8 @@ def _parse_join( | |||
|
|
|||
| kwargs["this"].set("joins", joins) | |||
|
|
|||
| return self.expression(exp.Join, **kwargs) | |||
| comments = [c for token in (method, side, kind) if token for c in token.comments] | |||
| return self.expression(exp.Join, comments=comments, **kwargs) | |||
There was a problem hiding this comment.
inline as a generator?
comments= ( . ...)
There was a problem hiding this comment.
We're going to expand the generator into the full list anyway, right? Will this be beneficial?
There was a problem hiding this comment.
yes because you're creating an extra list here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.