Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(postgres): improve parsing of array types closes #2034 #2040

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix(postgres): improve parsing of array types closes #2034 #2040

merged 1 commit into from
Aug 11, 2023

Conversation

tobymao
Copy link
Owner

@tobymao tobymao commented Aug 11, 2023

No description provided.

@tobymao tobymao requested a review from georgesittas August 11, 2023 16:50
georgesittas
georgesittas approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, nice! I haven't thoroughly checked the AST side-effects this causes, but I believe it's not breaking?

@tobymao
Copy link
Owner Author

tobymao commented Aug 11, 2023

don't think it should change anything

@tobymao tobymao merged commit 32eb129 into main Aug 11, 2023
@tobymao tobymao deleted the toby/arrays branch August 11, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobymao @georgesittas