Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: improve support for NVL2 function #2042

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented Aug 11, 2023

  • Convert NVL2 to CASE expression for dialects that don't support it
  • Stop transforming COALESCE into NVL for Doris dialect, because the latter is more restrictive (only 2 args).

Tested directly in the engine where it was easy to do + consulted docs for each dialect.

@georgesittas georgesittas merged commit c817e19 into main Aug 11, 2023
@georgesittas georgesittas deleted the jo/improve_support_for_nvl2 branch August 11, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants