Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(tsql): support adding multiple columns with ALTER TABLE #2140

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix(tsql): support adding multiple columns with ALTER TABLE #2140

merged 3 commits into from
Aug 31, 2023

Conversation

treysp
Copy link
Collaborator

@treysp treysp commented Aug 31, 2023

Most dialects repeat ADD COLUMN for every column being added: ALTER TABLE a ADD COLUMN b INT, ADD COLUMN c INT

tsql only puts ADD at the beginning of the column list: ALTER TABLE a ADD b INT, c INT

tobymao
tobymao reviewed Aug 31, 2023
View reviewed changes
sqlglot/generator.py Outdated Show resolved Hide resolved
@tobymao tobymao merged commit bd96d0c into main Aug 31, 2023
@tobymao tobymao deleted the trey/tsql-alter-mult-cols branch August 31, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treysp @tobymao