Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(tsql): generate SELECT INTO from CTAS #2237

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fix(tsql): generate SELECT INTO from CTAS #2237

merged 4 commits into from
Sep 18, 2023

Conversation

treysp
Copy link
Collaborator

@treysp treysp commented Sep 16, 2023

  • Removed temp table tests that use invalid CTAS syntax

tobymao
tobymao reviewed Sep 16, 2023
View reviewed changes
sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved
georgesittas
georgesittas approved these changes Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Toby's comment; looks good besides that

@tobymao tobymao merged commit f76ebb2 into main Sep 18, 2023
@tobymao tobymao deleted the trey/tsql-ctas branch September 18, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treysp @tobymao @georgesittas