Fix(dataframe): ensure Column.alias preserves quotes #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
approved these changes
Sep 18, 2023
georgesittas
commented
Sep 18, 2023
sqlglot/dataframe/sql/column.py
Outdated
|
|
||
| alias: exp.Expression = sqlglot.maybe_parse(name, dialect=SparkSession().dialect) | ||
| new_expression = exp.alias_( | ||
| self.column_expression, alias.this if isinstance(alias, exp.Column) else name |
There was a problem hiding this comment.
I check for exp.Column here because there were some tests where name was avg(...), generated in https://github.com/tobymao/sqlglot/blob/main/sqlglot/dataframe/sql/group.py#L24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here was that 1)
namewas parsed according to Spark, instead of using the session's dialect 2) if quotes were present inname, the whole alias name would be treated as an "unsafe identifier" into_identifier, which resulted in adding more quotes and thus generating incorrect SQL.