Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): parse RESTRICT constrain action #2267

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix(postgres): parse RESTRICT constrain action #2267

merged 2 commits into from
Sep 20, 2023

Conversation

Nitrino
Copy link
Contributor

@Nitrino Nitrino commented Sep 20, 2023

Postgres supports CASCADE and RESTRICT constrain actions.
CASCADE is parsed by the library without problems, but RESTRICT is not.
This PR fixes this

Docs
https://www.postgresql.org/docs/current/ddl-constraints.html

georgesittas
georgesittas approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Please make sure to also run make style before submitting a PR in the future.

tests/dialects/test_postgres.py Outdated Show resolved Hide resolved
@georgesittas georgesittas merged commit 61f85a4 into tobymao:main Sep 20, 2023
@Nitrino Nitrino deleted the fix-restrict-index-action branch September 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nitrino @georgesittas