Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(hive): don't generate BYTE when transpiling Oracle's VARCHAR(5 BYTE) #2358

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix(hive): don't generate BYTE when transpiling Oracle's VARCHAR(5 BYTE) #2358

merged 2 commits into from
Oct 2, 2023

Conversation

georgesittas
Copy link
Collaborator

@georgesittas georgesittas commented Oct 2, 2023 •
edited
Loading

Fixes #2356

This shouldn't be breaking, I remember adding support for the expression argument only to handle Oracle's BYTE, CHAR type specifiers, see 3ee16c5e8

georgesittas
georgesittas commented Oct 2, 2023
View reviewed changes
sqlglot/dialects/hive.py Outdated Show resolved Hide resolved
@georgesittas georgesittas merged commit e8273e2 into main Oct 2, 2023
@georgesittas georgesittas deleted the jo/remove_datatypesize_expression branch October 2, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobymao tobymao tobymao left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle BYTE statement in Oracle DDL to Spark
2 participants
@georgesittas @tobymao